improvement: allow multiple bounce marks and bounce sounds (gibs)#55
Open
WofWca wants to merge 2 commits intoec-:masterfrom
Open
improvement: allow multiple bounce marks and bounce sounds (gibs)#55WofWca wants to merge 2 commits intoec-:masterfrom
WofWca wants to merge 2 commits intoec-:masterfrom
Conversation
fb04d43 to
6f945d5
Compare
It's more "physically accurate" to decide whether to leave a mark based on velocity. This allows gibs to leave multiple marks, should they keep high velocity after the first impact.
b20307e to
25f7745
Compare
Allow playing the gib sound more than once, and keep leaving the blood trail even if the gib already hit something.
25f7745 to
9ff2dc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's more "physically accurate" to decide whether to leave a mark
and play a sound based on velocity.
This allows gibs to leave multiple marks and play the sound,
should they keep high velocity after the first impact.
Also keep leaving the blood trail even if the gib already hit something.
TODO: